This repository was archived by the owner on Feb 25, 2025. It is now read-only.
made android unit tests not require the host engine variant to exist #28925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blasten
reviewed
Sep 29, 2021
testing/run_tests.py
Outdated
| parser.add_argument('--android-variant', dest='android_variant', action='store', | ||
| default='android_debug_unopt', | ||
| help='The engine build variant to run java tests for') | ||
| help='The engine build variant to run java/android tests for') |
There was a problem hiding this comment.
nit: "java or android". I thought / was a path separator
blasten
approved these changes
Sep 29, 2021
gaaclarke
added
the
waiting for tree to go green
Member
Author
|
landing on red, the outstanding closure is a network flake |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 29, 2021
akbiggs
pushed a commit
to akbiggs/engine
that referenced
this pull request
Oct 1, 2021
dnfield
pushed a commit
to dnfield/engine
that referenced
this pull request
Oct 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue flutter/flutter#90903
The requirement for the host engine variant to exist was tripping up the CI bot.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.