This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Destroy overlay surfaces when the rasterizer is torn down #28894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blasten
force-pushed
the
add_to_app_pv
branch
from
6b068c8 to
a2249cd
Compare
jason-simmons
approved these changes
Sep 28, 2021
GaryQian
approved these changes
Sep 28, 2021
blasten
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 29, 2021
dnfield
pushed a commit
to dnfield/engine
that referenced
this pull request
Oct 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In add-to-app, cached engines allow to reuse existing c++ state. However, this state must be kept in synced with the platform state.
After an activity is destroyed, platform resources like Android views must be released, leaving the cached engine in a bad state when these resources are mapped to state in c++.
Related issues:
flutter/flutter#88880
googleads/googleads-mobile-flutter#265