Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Linux] Fix crash when a method channel is reassigned #28878

Merged
merged 4 commits into from
Sep 29, 2021
Merged

[Linux] Fix crash when a method channel is reassigned #28878

merged 4 commits into from
Sep 29, 2021

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Sep 26, 2021 •
edited
Loading

Fixes flutter/flutter#90817.

This is a prerequisite to fixing flutter/flutter#89729.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Sep 26, 2021
@dkwingsmt dkwingsmt mentioned this pull request Sep 27, 2021
Closed
gspencergoog
gspencergoog approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Good catch!

@dkwingsmt dkwingsmt mentioned this pull request Sep 28, 2021
Closed
@dkwingsmt dkwingsmt added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Sep 28, 2021
@dkwingsmt dkwingsmt merged commit 3c4f535 into flutter:master Sep 29, 2021
@dkwingsmt dkwingsmt deleted the linux-reassign-method-channel branch September 29, 2021 17:47
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 29, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 29, 2021
@engine-flutter-autoroll
3c4f535 [Linux] Fix crash when a method channel is reassigned (flutte…
b59b7cc 
…r/engine#28878)
akbiggs pushed a commit to akbiggs/engine that referenced this pull request Oct 1, 2021
@dkwingsmt @akbiggs
[Linux] Fix crash when a method channel is reassigned (flutter#28878)
199cb5f 
* Impl

* Format

* Doc
dnfield pushed a commit to dnfield/engine that referenced this pull request Oct 6, 2021
@dkwingsmt @dnfield
[Linux] Fix crash when a method channel is reassigned (flutter#28878)
0f2d2d3 
* Impl

* Format

* Doc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@robert-ancell robert-ancell Awaiting requested review from robert-ancell

1 more reviewer

@gspencergoog gspencergoog gspencergoog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-linux waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Linux engine] Replacing a method channel does not work

2 participants

@dkwingsmt @gspencergoog