Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Multiple fixes to text layout and line breaks #28642

Merged
merged 6 commits into from
Sep 20, 2021
Merged

[web] Multiple fixes to text layout and line breaks #28642

merged 6 commits into from
Sep 20, 2021

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Sep 15, 2021 •
edited
Loading

  • Modifications to the line breaking algorithm:
    • Allow break before/after parentheses and other punctuations when they are preceded/followed by whitespace.
    • Adjust the test fixtures accordingly.
  • Fix line breaking when maxEnd coincides with the end of a whitespace sequence.
  • Fix line breaking when there are consecutive non-breakable spans that don't fit in a single line.
  • Fix some edge cases that cause text layout to incorrectly take prohibited line breaks.
  • Avoid unnecessary recomputation of next line break.
  • Fix some test helpers to show correct info on failures.
  • Null safety improvements.

This required some screenshot updates: flutter/goldens#225

Fixes flutter/flutter#89586
Allows tests mentioned here to be unskipped.

@mdebbar mdebbar added the platform-web Code specifically for the web engine label Sep 15, 2021
@mdebbar mdebbar requested a review from yjbanov September 15, 2021 17:34
@google-cla google-cla bot added the cla: yes label Sep 15, 2021
@mdebbar mdebbar mentioned this pull request Sep 16, 2021
Merged
yjbanov
yjbanov reviewed Sep 16, 2021
View reviewed changes
yjbanov
yjbanov reviewed Sep 16, 2021
View reviewed changes
yjbanov
yjbanov approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdebbar mdebbar added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Sep 20, 2021
@fluttergithubbot fluttergithubbot merged commit 9e45508 into flutter:master Sep 20, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 20, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 20, 2021
@engine-flutter-autoroll
9e45508 [web] Multiple fixes to text layout and line breaks (flutter/…
d3c3983 
…engine#28642)
akbiggs pushed a commit to akbiggs/engine that referenced this pull request Sep 21, 2021
@mdebbar @akbiggs
[web] Multiple fixes to text layout and line breaks (flutter#28642)
1e7ac5d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 21, 2021
@engine-flutter-autoroll
9e45508 [web] Multiple fixes to text layout and line breaks (flutter/…
8bc78eb 
…engine#28642)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 21, 2021
@engine-flutter-autoroll
9e45508 [web] Multiple fixes to text layout and line breaks (flutter/…
47356bd 
…engine#28642)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 21, 2021
@engine-flutter-autoroll
9e45508 [web] Multiple fixes to text layout and line breaks (flutter/…
ff4dad3 
…engine#28642)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 21, 2021
@engine-flutter-autoroll
9e45508 [web] Multiple fixes to text layout and line breaks (flutter/…
a618e02 
…engine#28642)
@mdebbar mdebbar mentioned this pull request Sep 22, 2021
Merged
@mdebbar mdebbar deleted the fix_text branch January 17, 2023 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@yjbanov yjbanov yjbanov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Web] [HTML][regression] Text incorrectly wraps punctuation

3 participants

@mdebbar @yjbanov @fluttergithubbot