Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@iskakaushik
Copy link
Contributor

@iskakaushik iskakaushik commented Sep 13, 2021

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@iskakaushik iskakaushik added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Sep 13, 2021
@iskakaushik iskakaushik merged commit 468b431 into flutter:master Sep 13, 2021
@iskakaushik iskakaushik deleted the reland-benchmark branch September 13, 2021 20:58
@zanderso
Copy link
Member

Can this have a test in https://github.com/flutter/engine/blob/master/testing/benchmark/test/parse_and_send_test.dart ?

@iskakaushik
Copy link
Contributor Author

@CaseyHillers , the builder added here: https://github.com/flutter/engine/pull/28586/files#diff-9e73abde9fff445f31e5928e80d2d3f88847e02fd8f76d46f66f147fdc82786dR149, doesn't seem to be part of presubmits though i did not add presubmit: false. Is there any additional things I should do to make it part of presubmits?

@CaseyHillers
Copy link
Contributor

@iskakaushik Linux benchmarks (no-upload) is marked with bringup: true. We currently don't support a non-blocking way of running presubmit tests as this is intended for LED runs. You would need to promote it to blocking (see https://github.com/flutter/cocoon/blob/master/CI_YAML.md#adding-new-targets)

I filed flutter/flutter#90395 to track the feature request

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes needs tests waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exercise benchmark harness in presubmits.

4 participants