-
Notifications
You must be signed in to change notification settings - Fork 6k
Add flag to disable overlays #28312
Add flag to disable overlays #28312
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| static const bool disableOverlays = bool.fromEnvironment( | ||
| 'FLUTTER_WEB_DISABLE_OVERLAYS', | ||
| defaultValue: false, | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline, instead of forcing maximumOverlaySurfaces to be >= 2, let's treat maximumOverlaySurfaces == 1 as "overlays not supported". This will obviate the need for a second environment variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. PTAL
Adds an option to disable overlay canvases.
We create an overlay canvas (and new GL context) for each platform view, but we are hitting issues since the GL resources aren't shared between contexts.
This adds a flag to disable overlay canvases to work around the issue, but it may cause rendering glitches in the case where content is supposed to be overlaid on the platform view.
Workaround for flutter/flutter#86809
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.