Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

don't build flutter SDK artifacts for armv7 #28016

Merged
merged 2 commits into from
Nov 5, 2021
Merged

don't build flutter SDK artifacts for armv7 #28016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9020c6
don't build flutter SDK artifacts for armv7
ardera Aug 11, 2021
1f69319
add todo link in BUILD.gn
ardera Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,11 @@ if (flutter_prebuilt_dart_sdk) {

# Flutter SDK artifacts should only be built when either doing host builds, or
# for cross-compiled desktop targets.
# TODO: We can't build the engine artifacts for arm (32-bit) right now;
# see https://github.com/flutter/flutter/issues/74322
_build_engine_artifacts =
current_toolchain == host_toolchain || (is_linux && !is_chromeos) || is_mac
current_toolchain == host_toolchain ||
(is_linux && !is_chromeos && current_cpu != "arm") || is_mac

group("dart_sdk") {
if (_build_engine_artifacts) {
Expand Down
2 changes: 1 addition & 1 deletion tools/gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def is_host_build(args):
# target_os='linux' and linux-cpu='arm64'
# TODO(fujino): make host platform explicit
# https://github.com/flutter/flutter/issues/79403
return args.target_os is None or args.target_os == 'linux'
return args.target_os is None or (args.target_os == 'linux' and args.linux_cpu == 'arm64')

# Determines whether a prebuilt Dart SDK can be used instead of building one.
# We can use a prebuilt Dart SDK when:
Expand Down