Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@TheOneWithTheBraid
Copy link

This PR fixes the incorrectly set aria-live attribute in the web's semantics. Up to now, it has been set to true, which is an invalid value. According to MDN, it should be set to polite, assertive or off.

Moreover, several typos in the semantics test have been fixed.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

  • I don't think so.

Please note, there was an existing test I modified. Unfortunately, this test was expecting the incorrect value.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yjbanov yjbanov merged commit d8bbebe into flutter:master Aug 10, 2021
@TheOneWithTheBraid TheOneWithTheBraid deleted the aria-live-fix branch August 11, 2021 05:13
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 11, 2021
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants