Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix: modifier keys not recognized on macOS Web #27972

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Fix: modifier keys not recognized on macOS Web #27972

merged 1 commit into from
Aug 9, 2021

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Aug 9, 2021 •
edited
Loading

The framework has started using KeyboardEvent.location to recognize modifiers on Web, but the engine is not sending this field at all, which makes all modifiers unrecognized. This PR fixes that by adding this field.

Fixes flutter/flutter#87951.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Aug 9, 2021
@google-cla google-cla bot added the cla: yes label Aug 9, 2021
@dkwingsmt dkwingsmt requested a review from mdebbar August 9, 2021 20:54
@dkwingsmt dkwingsmt merged commit 3ee19b4 into flutter:master Aug 9, 2021
@dkwingsmt dkwingsmt deleted the fix-web-keyboard-location branch August 9, 2021 22:03
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 11, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 11, 2021
@engine-flutter-autoroll
3ee19b4 Fix: modifier keys not recognized on macOS Web (flutter/engin…
d83cd35 
…e#27972)
christopherfujino added a commit that referenced this pull request Aug 11, 2021
@christopherfujino @dkwingsmt
[flutter_releases] Flutter beta 2.5.0-5.0.pre Engine Cherrypicks (#28025
fbeb7e2 
)

* 'Update Dart SDK to efcdca0'
* Fix: modifier keys not recognized on macOS Web (#27972)
* Cherrypick .ci.yaml updates
* update licenses golden

Co-authored-by: Tong Mu <[email protected]>
@mdebbar mdebbar mentioned this pull request Aug 12, 2021
Closed
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
@dkwingsmt @filmil
Fix: modifier keys not recognized on macOS Web (flutter#27972)
5191443
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mdebbar mdebbar mdebbar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes cp: 2.5 platform-web Code specifically for the web engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RawKeyEvent.isMetaPressed no longer working on MacOS for Command key

2 participants

@dkwingsmt @mdebbar