This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll buildroot to c37164f39300c6e42560a5853e16a919688f7b86 #27967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Aug 9, 2021
|
(i tried this locally and solved my issue fwiw) |
|
For the failure of "Mac Android Debug Engine", the failure step doesn't even sound right "Verify exported symbols on release binaries". If you look at the steps before it too, it doesn't look like it is running GN or building anything. |
This eliminates the landmines hook. build/landmines.py writes out a .landmines file at the root of the buildroot. The first step of a `gclient sync` is to check for diffs between that file and the new one, and if found, a clobber is performed. We never actually use this functionality, and the code calls rmtree() which (at least on macos) appears to choke on symlinks. This deletes these scripts, and will be paired with the deletion of the first gclient hook in the DEPS file in flutter/engine during the roll. If we ever need this functionality, it's relatively straightforward to add it back. Issue: flutter/flutter#87960
|
#27980 eliminates that shard, which was only building Android Vulkan builds. See commit comment for details. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 11, 2021
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Apr 21, 2022
This eliminates the landmines hook. build/landmines.py writes out a .landmines file at the root of the buildroot. The first step of a `gclient sync` is to check for diffs between that file and the new one, and if found, a clobber is performed. We never actually use this functionality, and the code calls rmtree() which (at least on macos) appears to choke on symlinks. This deletes these scripts, and will be paired with the deletion of the first gclient hook in the DEPS file in flutter/engine during the roll. If we ever need this functionality, it's relatively straightforward to add it back. Issue: flutter/flutter#87960
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates the landmines hook.
build/landmines.py writes out a .landmines file at the root of the
buildroot. The first step of a
gclient syncis to check for diffsbetween that file and the new one, and if found, a clobber is performed.
We never actually use this functionality, and the code calls rmtree()
which (at least on macos) appears to choke on symlinks.
This deletes these scripts, and will be paired with the deletion of the
first gclient hook in the DEPS file in flutter/engine during the roll.
If we ever need this functionality, it's relatively straightforward to
add it back.
Issue: flutter/flutter#87960
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.