Fix StandardMessageCodec test leaks #27959
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| std::unique_ptr<StandardMessageCodec>>; | ||
| auto it = sInstances->find(serializer); | ||
| if (it == sInstances->end()) { | ||
| static auto sInstances = std::map<const StandardCodecSerializer*, |
There was a problem hiding this comment.
The missing static is obviously a mistake, but the other changes you've made here are breaking deliberate behavior and violate style: https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
There was a problem hiding this comment.
That destructor ordering argument makes sense, thanks for the link. Fixed and added tests. Also did the same in StandardMethodCodec, as that's leaking across tests as well.
bdero
force-pushed
the
bdero/fix-test-leaks
branch
2 times, most recently
from
f50c270 to
6797fda
Compare
bdero
force-pushed
the
bdero/fix-test-leaks
branch
from
6797fda to
84666c4
Compare
2 participants
Fix a memory leak that triggers asan traces in the codec tests.