This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix routerinformationupdate can take complex json #27932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdebbar
approved these changes
Aug 6, 2021
| browserHistory.setRouteName( | ||
| arguments!.tryString('location'), | ||
| state: arguments.tryString('state'), | ||
| state: arguments['state'], |
There was a problem hiding this comment.
@yjbanov should we add a tryObject()?
There was a problem hiding this comment.
what is the point of tryObject though? it is already an object?
There was a problem hiding this comment.
Without a type, it's dynamic not Object?. Not sure if that's an important distinction or not.
There was a problem hiding this comment.
Btw, feel free to submit the PR. If we need to change it to Object? we can do so later.
There was a problem hiding this comment.
I can add that if that makes sense, btw what is the motive to avoid as String? and use tryString
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 11, 2021
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Apr 21, 2022
* Fix routerinformationupdate can take complex json * comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#87823
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.