Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@gaaclarke
Copy link
Member

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Aug 6, 2021
@gaaclarke gaaclarke requested a review from iskakaushik August 6, 2021 17:23
@gaaclarke gaaclarke added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Aug 6, 2021
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux Android AOT Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Aug 6, 2021
@chinmaygarde
Copy link
Member

Can we just try to patch the script to not fail on Python 3.9? If that is not trivial, can we document the issue in a bug for followup?

@chinmaygarde
Copy link
Member

From triage, another data point from Zach: He is running 3.9.2 and that seems to be fine. We should definitely dig a bit deeper to figure out why newer versions might be no good.

@gaaclarke
Copy link
Member Author

@zanderso @chinmaygarde Okay, I removed the note about 3.9. We still need a note about 3.7. We'll consider anything that doesn't work beyond 3.7 a bug.

I'll see if I can reproduce the 3.9 bug. The problem would only arise for me if a rebuild was actually triggered fwiw, it's a runtime error.

@gaaclarke gaaclarke added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Aug 12, 2021
@chinmaygarde
Copy link
Member

chinmaygarde commented Aug 12, 2021

sgtm. I checked my python version and it was 3.8.2. I'll update it and be on the lookout for this issue as well.

@fluttergithubbot fluttergithubbot merged commit 9cefdf8 into flutter:master Aug 12, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2021
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants