This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] update TODO format to match flutter repo and fix names, more code cleanup #27796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
mdebbar
approved these changes
Jul 29, 2021
| // resetting the tree would be a matter of reconstructing | ||
| // the new resolved tree. | ||
| font.reset(); | ||
| //ignore: prefer_foreach |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| //ignore: prefer_foreach | |
| // ignore: prefer_foreach |
Comment on lines
86
to
87
| // Didn't use `this.boxes` because we want it to be non-null in this | ||
| // constructor. |
Contributor
There was a problem hiding this comment.
This comment isn't valid anymore.
Suggested change
| // Didn't use `this.boxes` because we want it to be non-null in this | |
| // constructor. |
Contributor
Author
|
merging on infra fail. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 30, 2021
… more code cleanup (flutter/engine#27796)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 30, 2021
… more code cleanup (flutter/engine#27796)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 30, 2021
… more code cleanup (flutter/engine#27796)
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Apr 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
flutter/flutter#86891
Pre-launch Checklist
writing and running engine tests.
///).