Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented Jul 28, 2021

This needs to match what's in flutter_deps, otherwise, we'll get the weird failure we saw. I'll update the module to give a more descriptive error.

flutter/flutter#86892

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@CaseyHillers CaseyHillers requested a review from blasten July 28, 2021 23:18
@google-cla google-cla bot added the cla: yes label Jul 28, 2021
@CaseyHillers
Copy link
Contributor Author

Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. definitely, good error messages are time savers. Ideally, they are actionable by anyone.

@CaseyHillers CaseyHillers added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 28, 2021
@fluttergithubbot fluttergithubbot merged commit 1eeb722 into flutter:master Jul 29, 2021
@CaseyHillers CaseyHillers deleted the fix-dep branch July 29, 2021 00:24
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 29, 2021
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Jul 29, 2021
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants