Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Do not call CoreWindow::Visible from raster thread #27760

Merged
merged 3 commits into from
Aug 7, 2021
Merged

Do not call CoreWindow::Visible from raster thread #27760

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32da16b
Do not call CoreWindow::Visible from raster thread
knopp Jul 28, 2021
0d24582
tweak
knopp Jul 28, 2021
dbba863
Add link to issue
knopp Aug 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion shell/platform/windows/flutter_window_winuwp.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,13 @@ float FlutterWindowWinUWP::GetDpiScale() {
}

bool FlutterWindowWinUWP::IsVisible() {
return window_.Visible();
// This is called from raster thread as an optimization to not wait for vsync
// if window is invisible. However CoreWindow is not agile so we can't call
// Visible() from raster thread. For now assume window is always visible.
// Possible solution would be to register a VisibilityChanged handler and
// store the visiblity state in a variable. TODO(knopp)
Copy link
Member

@chinmaygarde chinmaygarde Aug 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please file a bug and cross reference it in the TODO? Otherwise these TODOs tend to get lost. But otherwise LGTM.

// https://github.com/flutter/flutter/issues/87870
return true;
}

void FlutterWindowWinUWP::OnDpiChanged(
Expand Down