This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add a run_tests flag that captures core dumps from engine unit tests and runs a GDB script #27742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
Jul 27, 2021
testing/run_tests.py
Outdated
| import glob | ||
| import os | ||
| import re | ||
| import resource |
There was a problem hiding this comment.
Looks like this doesn't exist on Windows.
There was a problem hiding this comment.
Fixed this to only set the core dump ulimit on Linux
(In theory this approach could also work on macOS. But the directory that holds core dumps on macOS is not writable by the jobs on the LUCI bots).
jason-simmons
force-pushed
the
luci_core_capture
branch
from
fc270b3 to
095cd9b
Compare
zanderso
approved these changes
Jul 28, 2021
|
|
||
|
|
||
| def RunCCTests(build_dir, filter, coverage): | ||
| try: |
There was a problem hiding this comment.
nit: remove extra newline above.
| ]) | ||
| os.unlink(core_path) | ||
| raise | ||
|
|
There was a problem hiding this comment.
nit: need two newlines between functions
…and runs a GDB script The output of the GDB script will be placed in a directory that can be uploaded to cloud storage by the LUCI recipe.
jason-simmons
force-pushed
the
luci_core_capture
branch
from
095cd9b to
3723a22
Compare
jason-simmons
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 30, 2021
…t tests and runs a GDB script (flutter/engine#27742)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 30, 2021
…t tests and runs a GDB script (flutter/engine#27742)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 30, 2021
…t tests and runs a GDB script (flutter/engine#27742)
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
…and runs a GDB script (flutter#27742)
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Apr 21, 2022
…and runs a GDB script (flutter#27742)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of the GDB script will be placed in a directory that can be
uploaded to cloud storage by the LUCI recipe.