Sets accessibility panel title when route changes #27713

chunhtai · 2021-07-26T20:30:48Z

I tested this change and it is working before and after api 28. Unfortunately I can't find a way to make the Unit test to run in API < 28, so I have updated the existing test to check for panel title instead of notification.

Fixes flutter/flutter#86575

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

blasten · 2021-07-26T21:33:19Z

shell/platform/android/io/flutter/view/AccessibilityBridge.java


  /**
-   * Creates a {@link AccessibilityEvent#TYPE_WINDOW_STATE_CHANGED} and sends the event to Android's
+   * Called when needs to inform the TalkBack user about window name changes.


Suggested change

* Called when needs to inform the TalkBack user about window name changes.

* Informs TalkBack user about window name changes.

blasten · 2021-07-26T21:35:39Z

shell/platform/android/io/flutter/view/AccessibilityBridge.java

+  @TargetApi(28)
+  @RequiresApi(28)


Suggested change

@TargetApi(28)

@RequiresApi(28)

@TargetApi(Build.VERSION_CODES.P)

@RequiresApi(Build.VERSION_CODES.P)

shell/platform/android/io/flutter/view/AccessibilityBridge.java

blasten · 2021-07-26T22:09:54Z

shell/platform/android/io/flutter/view/AccessibilityBridge.java

+
+  @TargetApi(28)
+  @RequiresApi(28)
+  @VisibleForTesting


You can use: ReflectionHelpers.setStaticField(Build.VERSION.class, "SDK_INT", <api-number>);

http://robolectric.org/javadoc/3.0/org/robolectric/util/ReflectionHelpers.html

I'm not sure why we haven't used this pattern yet, but maybe it's time to re-evaluate @VisibleForTesting methods if they are working around this issue.

I found a different way to mock the view, so i don't need the VisibleForTesting

for some reason using Build.VERSION_CODES.P causes the Linux_unopt failure

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8840536145538768400/+/u/android_lint/dart_bin_main.dart/stdout

that is weird, since the constant P = 28. My only guess is that we are using something prior to https://cs.android.com/android/_/android/platform/frameworks/base/+/3da5f3b2ddf35ed436cd9a0c6a349c59c97f8d78

cc @dnfield maybe this line https://github.com/flutter/engine/blob/master/tools/android_lint/bin/main.dart#L77 ?

blasten · 2021-07-28T00:00:55Z

shell/platform/android/io/flutter/view/AccessibilityBridge.java

  /**
-   * Creates a {@link AccessibilityEvent#TYPE_WINDOW_STATE_CHANGED} and sends the event to Android's
-   * accessibility system.
+   * Informs TalkBack user about window name changes.


Suggested change

* Informs TalkBack user about window name changes.

* Informs the TalkBack user about window name changes.

Apologies about the previous edit

blasten

LGTM

fluttergithubbot · 2021-07-28T17:39:02Z

This pull request is not suitable for automatic merging in its current state.

The status or check suite Linux Android AOT Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux Android Debug Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux Fuchsia has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac Android AOT Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac Android Debug Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac iOS Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows Android AOT Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows UWP Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

blasten · 2021-07-28T21:56:20Z

@CaseyHillers @godofredoc are these failures related to recent changes?

CaseyHillers · 2021-07-28T22:01:03Z

Yes, when https://flutter-review.googlesource.com/c/recipes/+/16262 lands, these builds can be retried

…gine#27713)

flutter-dashboard bot added the platform-android label Jul 26, 2021

google-cla bot added the cla: yes label Jul 26, 2021

chunhtai requested review from blasten and goderbauer July 26, 2021 20:30

blasten reviewed Jul 26, 2021

View reviewed changes

shell/platform/android/io/flutter/view/AccessibilityBridge.java Show resolved Hide resolved

blasten reviewed Jul 26, 2021

View reviewed changes

chunhtai requested a review from blasten July 27, 2021 16:56

blasten reviewed Jul 28, 2021

View reviewed changes

blasten approved these changes Jul 28, 2021

View reviewed changes

chunhtai added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 28, 2021

fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 28, 2021

chunhtai added 4 commits July 29, 2021 09:28

Sets accessibility panel title when route changes

f17517e

update

49ee7f4

update

7e27fa6

update

189c3cb

chunhtai force-pushed the issues/86575 branch from 957f436 to 189c3cb Compare July 29, 2021 16:29

chunhtai added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 29, 2021

fluttergithubbot merged commit c889b02 into flutter:master Jul 29, 2021

engine-flutter-autoroll mentioned this pull request Jul 29, 2021

Roll Engine from 884e9dacb919 to f0fd3e9c6859 (4 revisions) flutter/flutter#87296

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 29, 2021

c889b02 Sets accessibility panel title when route changes (flutter/en…

8e28ab6

…gine#27713)

engine-flutter-autoroll mentioned this pull request Jul 29, 2021

Roll Engine from 884e9dacb919 to 1bf0734f4aec (6 revisions) flutter/flutter#87303

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 29, 2021

c889b02 Sets accessibility panel title when route changes (flutter/en…

f6e59ad

…gine#27713)

engine-flutter-autoroll mentioned this pull request Jul 30, 2021

Roll Engine from 884e9dacb919 to 9d840d120a3a (10 revisions) flutter/flutter#87323

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2021

c889b02 Sets accessibility panel title when route changes (flutter/en…

ebe418b

…gine#27713)

engine-flutter-autoroll mentioned this pull request Jul 30, 2021

Roll Engine from 884e9dacb919 to d71ba5686df1 (13 revisions) flutter/flutter#87327

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2021

c889b02 Sets accessibility panel title when route changes (flutter/en…

66f72c0

…gine#27713)

engine-flutter-autoroll mentioned this pull request Jul 30, 2021

Roll Engine from 884e9dacb919 to 72c8e5521b62 (14 revisions) flutter/flutter#87331

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2021

c889b02 Sets accessibility panel title when route changes (flutter/en…

1f8b1bc

…gine#27713)

naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021

Sets accessibility panel title when route changes (flutter#27713)

f3f642c

filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022

Sets accessibility panel title when route changes (flutter#27713)

26ee607

	* Called when needs to inform the TalkBack user about window name changes.
	* Informs TalkBack user about window name changes.

	* Informs TalkBack user about window name changes.
	* Informs the TalkBack user about window name changes.

Sets accessibility panel title when route changes #27713

Sets accessibility panel title when route changes #27713

Uh oh!

Conversation

chunhtai commented Jul 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blasten Jul 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blasten left a comment

Choose a reason for hiding this comment

Uh oh!

fluttergithubbot commented Jul 28, 2021

Uh oh!

blasten commented Jul 28, 2021

Uh oh!

CaseyHillers commented Jul 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chunhtai commented Jul 26, 2021 •

edited

Loading

blasten Jul 27, 2021 •

edited

Loading