Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@Renzo-Olivares
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares commented Jul 25, 2021

Description

This change adds support for the IME_FLAG_NO_PERSONALIZED_LEARNING on Android see more details here. There is no equivalent on iOS.

Framework PR: flutter/flutter#87002

Related Issues

Fixes flutter/flutter#73046

Tests

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Jul 25, 2021
@Renzo-Olivares Renzo-Olivares changed the title Add support for IME Add support for IME_FLAG_NO_PERSONALIZED_LEARNING on Android Jul 25, 2021
@Renzo-Olivares Renzo-Olivares requested a review from justinmc July 26, 2021 15:02
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

The only thing to consider is the name requestPrivacy, as you pointed out in the framework PR. At first glance it sounds like it could be mistaken by developers for doing what obscureText does, but I don't have a better idea... The style guide has some guidance on naming but nothing really relevant here. Maybe @HansMuller has an opinion?

@Renzo-Olivares Renzo-Olivares requested a review from GaryQian July 26, 2021 21:05
@GaryQian
Copy link
Contributor

+1 on the name reconsideration. requestPrivacy doesn't sound quite intuitive and has no indication it is for the IME without going deeper to read the docs. The Privacy part of the name doesn't really carry the nuance or detail to describe what the flag actually does.

@Renzo-Olivares Renzo-Olivares added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 29, 2021
@fluttergithubbot fluttergithubbot merged commit 169bb4c into flutter:master Jul 30, 2021
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add TextInputConfiguration option for enabling Android "incognito keyboard"

4 participants