Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reland use a pbuffer surface when in the background #27629

Merged
merged 2 commits into from
Jul 21, 2021
Merged

Reland use a pbuffer surface when in the background #27629

merged 2 commits into from
Jul 21, 2021

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Jul 21, 2021 •
edited
Loading

Differences from last time:

  • We now pull in build-tool 30.0.2 (Roll to buildtools 30.0.2 #27622) as part of gclient sync
  • I updated gradle.properties to make sure gradle doesn't try to download android deps.

Fixes flutter/flutter#73675 again

@google-cla google-cla bot added the cla: yes label Jul 21, 2021
@dnfield dnfield mentioned this pull request Jul 21, 2021
Closed
@dnfield dnfield requested review from blasten and jason-simmons July 21, 2021 20:28
@dnfield dnfield merged commit 9970b94 into flutter:master Jul 21, 2021
@dnfield dnfield deleted the raster_pbuf branch July 21, 2021 22:07
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 21, 2021
@engine-flutter-autoroll
9970b94 Reland use a pbuffer surface when in the background (flutter/…
d30ecf3 
…engine#27629)
@zanderso zanderso mentioned this pull request Jul 27, 2021
Closed
@dnfield dnfield mentioned this pull request Jul 27, 2021
Merged
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
@dnfield
Reland use a pbuffer surface when in the background (flutter#27629)
6a3f150 
* Reland "Use a Pbuffer surface when the onscreen surface is not available for snapshotting on Android (flutter#27141)" (flutter#27607)"

This reverts commit 0c121d3.

* Do not let gradle download SDK deps
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jason-simmons jason-simmons Awaiting requested review from jason-simmons

1 more reviewer

@blasten blasten blasten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Picture.toImage/Scene.toImage does not work if Android app is in background and GPU images are in picture.

2 participants

@dnfield @blasten