This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Delete unused CI scripts #27606
Merged
Delete unused CI scripts #27606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
approved these changes
Jul 20, 2021
Member
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
LGTM once the recipes land and the "Scenario App Integration Tests" tests pass.
Contributor
Author
|
Need to update scenarios.py too - that's in https://flutter-review.googlesource.com/c/recipes/+/15821 |
dnfield
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 21, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 21, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 21, 2021
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs https://flutter-review.googlesource.com/c/recipes/+/15820 for the iOS side
None of these are used anymore - the firebase_xctest was never used and only would have worked from a local workstation. However, it wouldn't work any more with the way Scenario app is built now. The main blocker to testing iOS on firebase is signing - if we want to test on a real device on iOS we have to figure that out first and this script would have to be re-written anyway.
Part of flutter/flutter#84618