[flutter_releases] update .ci.yaml and pin xcode to 11 #27421
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
CaseyHillers
left a comment
CaseyHillers
left a comment
There was a problem hiding this comment.
LGTM - Thanks for updating the releases with this
.ci.yaml
Outdated
| {"name":"builder_mac_engine","path":"builder"} | ||
| ] | ||
| os: Mac-10.15 | ||
| xcode: "11e708" # Xcode 12 |
There was a problem hiding this comment.
Why does this need to explicitly be a string? Shouldn't it be loaded as a json string anyways?
There was a problem hiding this comment.
I had a pre-submit ci.yaml validation error. I think a value that starts with an integer is assumed to be a number, and then the e made it a parse error? Using this https://www.convertjson.com/yaml-to-json.htm I get 11e708 -> null
There was a problem hiding this comment.
I'll give github credit, they have a yaml syntax coloring in their diff view, and the 11e708 was a different color than the strings. I don't know the yaml parse rules, but apparently github does :)
There was a problem hiding this comment.
ok, it's actually 11e708 is parsed as a number in scientific notation.
|
The CI failures look related. |
christopherfujino
changed the title
|
Should probably apply this fix #27454 |
|
You'll need to rebase with tip of tree to fix the failing checks |
You mean tip of .ci.yaml? Is cocoon actually parsing these properties? |
No, I forgot this is a release cherry-pick :-) Carry on, i'm not sure how we fix these tips of issues (or if we just ack them) |
|
closing in favor of: #27487 |
|
@christopherfujino did you mean to close this? |
|
|
Oh, nvm, i see what you mean :P |
4 participants
for the most part, brought this in sync with the ToT .ci.yaml, minus
Linux Benchmarksand somerunIffields.Related to #27415
Part of flutter/flutter#86566