Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@zanderso
Copy link
Member

Reverts #27332

I don't know why this didn't fail in presubmit:

https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Unopt/647/overview

../../flutter/shell/platform/android/test/io/flutter/embedding/android/FlutterActivityAndFragmentDelegateTest.java:393: error: method onCreateView in class FlutterActivityAndFragmentDelegate cannot be applied to given types;
    delegate.onCreateView(null, null, null);
            ^
  required: LayoutInflater,ViewGroup,Bundle,int
  found: <null>,<null>,<null>
  reason: actual and formal argument lists differ in length
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error

/cc @ajmalk

…ed to an Android Activity. (#27332)"

This reverts commit 317166d.
@zanderso
Copy link
Member Author

Reverting tip-of-tree commit without running presubmits to green the tree.

@zanderso zanderso merged commit 093c4ed into master Jul 14, 2021
@zanderso zanderso deleted the revert-27332-feature/flutter-fragment-no-activity branch July 14, 2021 03:35
@dnfield
Copy link
Contributor

dnfield commented Jul 14, 2021

LGTM

@dnfield
Copy link
Contributor

dnfield commented Jul 14, 2021

This fails locally after merging up with master - it seems like the patch may have been against an older version of master and worked in presubmit, but failed when merging to head.

@dnfield
Copy link
Contributor

dnfield commented Jul 14, 2021

Yeah that's exactly what happened.

dnfield added a commit to dnfield/engine that referenced this pull request Jul 14, 2021
@ajmalk
Copy link
Contributor

ajmalk commented Jul 14, 2021

Oh man just my luck. 🙃

Attempt 2: #27397

@ajmalk
Copy link
Contributor

ajmalk commented Jul 14, 2021

You might want to reopen flutter/flutter#85326. I don't think I have permission to do that?

@dnfield
Copy link
Contributor

dnfield commented Jul 14, 2021

I already opened a reland of this here: #27386

moffatman pushed a commit to moffatman/engine that referenced this pull request Aug 5, 2021
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants