This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Revert "Make FlutterFragment usable without requiring it to be attached to an Android Activity." #27382
Merged
zanderso
merged 1 commit into
master
from
revert-27332-feature/flutter-fragment-no-activity
Jul 14, 2021
Merged
Revert "Make FlutterFragment usable without requiring it to be attached to an Android Activity." #27382
zanderso
merged 1 commit into
master
from
revert-27332-feature/flutter-fragment-no-activity
Jul 14, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Reverting tip-of-tree commit without running presubmits to green the tree. |
Contributor
|
LGTM |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 14, 2021
…e attached to an Android Activity. (flutter#27332)" (flutter/engine#27382)
Contributor
|
This fails locally after merging up with master - it seems like the patch may have been against an older version of master and worked in presubmit, but failed when merging to head. |
Contributor
|
Yeah that's exactly what happened. |
dnfield
added a commit
to dnfield/engine
that referenced
this pull request
Jul 14, 2021
…e attached to an Android Activity. (flutter#27332)" (flutter#27382)" This reverts commit 093c4ed.
8 tasks
Contributor
|
Oh man just my luck. 🙃 Attempt 2: #27397 |
Contributor
|
You might want to reopen flutter/flutter#85326. I don't think I have permission to do that? |
Contributor
|
I already opened a reland of this here: #27386 |
moffatman
pushed a commit
to moffatman/engine
that referenced
this pull request
Aug 5, 2021
…ed to an Android Activity. (flutter#27332)" (flutter#27382) This reverts commit 317166d.
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
…ed to an Android Activity. (flutter#27332)" (flutter#27382) This reverts commit 317166d.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #27332
I don't know why this didn't fail in presubmit:
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Unopt/647/overview
/cc @ajmalk