Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

NNBD migration for scenario_app #27362

Merged
merged 1 commit into from
Jul 13, 2021
Merged

NNBD migration for scenario_app #27362

merged 1 commit into from
Jul 13, 2021

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Jul 13, 2021

Migrate scenario app to NNBD

@dnfield dnfield requested review from gspencergoog and xster July 13, 2021 17:28
@google-cla google-cla bot added the cla: yes label Jul 13, 2021
@dnfield dnfield requested a review from zanderso July 13, 2021 17:34
@dnfield dnfield added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 13, 2021
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Jul 13, 2021

This pull request is not suitable for automatic merging in its current state.

  • This commit has empty status or empty checks. Please check the Google CLA status is present and Flutter Dashboard application has multiple checks.

@dnfield
Copy link
Contributor Author

dnfield commented Jul 13, 2021

@godofredoc @keyonghan - I'm not sure what's controlling the filtering here, but this should have triggered some Android and/or iOS builds. I think we probably don't do the iOS build on presubmit, but I'm pretty sure the Android one would have run. I'll see if I can find where the filter is...

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 13, 2021
@dnfield dnfield merged commit 462d245 into flutter:master Jul 13, 2021
@dnfield
Copy link
Contributor Author

dnfield commented Jul 13, 2021

Errr... I'm not sure what that bot message means and I just hit the land button.

@dnfield dnfield deleted the scenario_nnbd branch July 13, 2021 17:59
@keyonghan
Copy link
Contributor

keyonghan commented Jul 13, 2021

@godofredoc @keyonghan - I'm not sure what's controlling the filtering here, but this should have triggered some Android and/or iOS builds. I think we probably don't do the iOS build on presubmit, but I'm pretty sure the Android one would have run. I'll see if I can find where the filter is...

It is controlled by run_if in .ci.yaml. Here no LUCI builders are scheduled, I guess some delay, or cocoon backend error when triggering/scheduling. /cc @yusufm Do you mind helping take a look?

@dnfield
Copy link
Contributor Author

dnfield commented Jul 13, 2021

Ahh ok - it wasn't a runIf issue, it looks like they just didn't get scheduled.

zanderso added a commit that referenced this pull request Jul 13, 2021
@zanderso
Revert "NNBD migration for scenario_app (#27362)"
769d503 
This reverts commit 462d245.
@zanderso zanderso mentioned this pull request Jul 13, 2021
Merged
zanderso added a commit that referenced this pull request Jul 13, 2021
@zanderso
Revert "NNBD migration for scenario_app (#27362)" (#27364)
57720b2 
This reverts commit 462d245.
dnfield added a commit to dnfield/engine that referenced this pull request Jul 13, 2021
@dnfield
Revert "Revert "NNBD migration for scenario_app (flutter#27362)" (flu…
62d5802 
…tter#27364)"

This reverts commit 57720b2.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 13, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2021
@engine-flutter-autoroll
462d245 NNBD migration for scenario_app (flutter/engine#27362)
a6ea789
dnfield added a commit that referenced this pull request Jul 13, 2021
@dnfield
Scenario nnbd (#27365)
b57c502 
* Revert "Revert "NNBD migration for scenario_app (#27362)" (#27364)"

This reverts commit 57720b2.

* analysis issues

* no sound null safety because frontend_server is not
@CaseyHillers CaseyHillers mentioned this pull request Jul 13, 2021
Closed
5 tasks
moffatman pushed a commit to moffatman/engine that referenced this pull request Aug 5, 2021
@dnfield @moffatman
NNBD migration for scenario_app (flutter#27362)
df5538c
moffatman pushed a commit to moffatman/engine that referenced this pull request Aug 5, 2021
@zanderso @moffatman
Revert "NNBD migration for scenario_app (flutter#27362)" (flutter#27364)
ba3efb1 
This reverts commit 462d245.
moffatman pushed a commit to moffatman/engine that referenced this pull request Aug 5, 2021
@dnfield @moffatman
Scenario nnbd (flutter#27365)
be51d25 
* Revert "Revert "NNBD migration for scenario_app (flutter#27362)" (flutter#27364)"

This reverts commit 57720b2.

* analysis issues

* no sound null safety because frontend_server is not
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
@dnfield
NNBD migration for scenario_app (flutter#27362)
8d74a95
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
@zanderso
Revert "NNBD migration for scenario_app (flutter#27362)" (flutter#27364)
4eb9276 
This reverts commit 462d245.
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
@dnfield
Scenario nnbd (flutter#27365)
d69d9d7 
* Revert "Revert "NNBD migration for scenario_app (flutter#27362)" (flutter#27364)"

This reverts commit 57720b2.

* analysis issues

* no sound null safety because frontend_server is not
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xster xster Awaiting requested review from xster

@gspencergoog gspencergoog Awaiting requested review from gspencergoog

1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dnfield @fluttergithubbot @keyonghan @zanderso