This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] make dart_runner work with cfv2 #27226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chaselatta
force-pushed
the
dart-v2-runner
branch
from
90a9750 to
3cfdea8
Compare
chandarrengoog
approved these changes
Jul 8, 2021
chaselatta
force-pushed
the
dart-v2-runner
branch
from
3cfdea8 to
fdb213d
Compare
chaselatta
added
the
waiting for tree to go green
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
arbreng
approved these changes
Jul 8, 2021
Adds support for running the dart runner as a CFv2 component. The runner has been refactored to launch in both a v1 environemnt as well as a v2 environment.
chaselatta
force-pushed
the
dart-v2-runner
branch
from
fdb213d to
39e6086
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 9, 2021
moffatman
pushed a commit
to moffatman/engine
that referenced
this pull request
Aug 5, 2021
Adds support for running the dart runner as a CFv2 component. The runner has been refactored to launch in both a v1 environemnt as well as a v2 environment.
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
Adds support for running the dart runner as a CFv2 component. The runner has been refactored to launch in both a v1 environemnt as well as a v2 environment.
akbiggs
reviewed
Sep 7, 2021
| binary = "dart_jit${product_suffix}_runner" | ||
|
|
||
| cmx_file = rebase_path("meta/dart_jit${product_suffix}_runner.cmx") | ||
| cml_file = rebase_path("meta/dart_jit${product_suffix}_runner.cml") |
Contributor
There was a problem hiding this comment.
OOC I noticed we don't have a corresponding cml_file = dart_aot${product_suffix}_runner.cml line in this PR - is that an oversight or intentional?
akbiggs
added a commit
that referenced
this pull request
Sep 8, 2021
This was referenced Sep 8, 2021
akbiggs
added a commit
that referenced
this pull request
Sep 14, 2021
Bug: fxb/79871 The code is still using the CFv1 implementation, so this should not affect the existing behavior. For this version of the PR, I forked the existing DartComponentController. There were a few reasons for this: Reduces the chance of the change breaking existing tests during Fuchsia GI. Makes the V2 version of the DartComponentController simpler to read. Makes it easier to switch over to using the V2 version of the DartComponentController once the migration is ready to happen (less cleanup). The rate of changes to the DartComponentController is slow so there shouldn't be much maintenance required for the fork. Changes to the DartRunner itself will happen in a follow-up PR - this PR only verifies that the ComponentController builds. Relands GN and C++ changes for #27226 after rollback in #28036.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for running the dart runner as a CFv2 component.
The runner has been refactored to launch in both a v1 environemnt
as well as a v2 environment.