Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Avoid capturing raw pointers to the SkPicture/DisplayList used by the RasterizeToImage draw callback #27123

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Avoid capturing raw pointers to the SkPicture/DisplayList used by the RasterizeToImage draw callback #27123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions lib/ui/painting/picture.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ Dart_Handle Picture::toImage(uint32_t width,
Dart_Handle raw_image_callback) {
if (display_list_) {
return RasterizeToImage(
[display_list = display_list_.get()](SkCanvas* canvas) {
[display_list = display_list_](SkCanvas* canvas) {
display_list->RenderTo(canvas);
},
width, height, raw_image_callback);
Expand Down Expand Up @@ -91,10 +91,8 @@ Dart_Handle Picture::RasterizeToImage(sk_sp<SkPicture> picture,
uint32_t height,
Dart_Handle raw_image_callback) {
return RasterizeToImage(
[sk_picture = picture.get()](SkCanvas* canvas) {
canvas->drawPicture(sk_picture);
},
width, height, raw_image_callback);
[picture](SkCanvas* canvas) { canvas->drawPicture(picture); }, width,
height, raw_image_callback);
}

Dart_Handle Picture::RasterizeToImage(
Expand Down