Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Implement a DisplayList mechanism similar to the Skia SkLiteDL mechanism #26928

Merged
merged 26 commits into from
Jul 1, 2021
Merged

Implement a DisplayList mechanism similar to the Skia SkLiteDL mechanism #26928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
b9f69e3
Implement a DisplayList mechanism similar to the Skia SkLiteDL mechanism
flar Jun 15, 2021
b681d3f
fix licenses and a potential source of bulk compare failures
flar Jun 24, 2021
45d4cfd
fix shell test expecting string output for cache stats
flar Jun 24, 2021
f3da850
use std::numeric_limits for min/max float values
flar Jun 24, 2021
921d21d
fix windows compile errors due to structure packing
flar Jun 24, 2021
30c0380
Fix missing save layer flags
flar Jun 24, 2021
e021fef
switch to enum classes and fully implement SkC::drawPicture
flar Jun 24, 2021
285815b
adopt review suggestions on naming style
flar Jun 24, 2021
3a39b55
add alignment pragmas to rein in Windows x64 compiler wasted bytes
flar Jun 25, 2021
5c0e31f
remove the ColorFilter workaround from unit test now that Skia bug is…
flar Jun 25, 2021
3e34f1a
naming style for DLOp fields
flar Jun 25, 2021
8b3f915
switch to EXPECT for byte count test to see how many tests fail on Wi…
flar Jun 25, 2021
90a7b90
implement ImageRect constraint and pack ClipOp better for Windows (ho…
flar Jun 25, 2021
3535b78
add unit testing of DrawTextBlob
flar Jun 25, 2021
b8399f3
more style guide name changes and more testing of dl.Equals
flar Jun 26, 2021
5f16bcc
break up complicated unit tests and enable experimental DL test
flar Jun 26, 2021
0b275af
minor formatting and simplification of DL unit tests
flar Jun 26, 2021
d98decd
flush out render testing matrix and fix shadow bounds
flar Jun 26, 2021
6608c5f
Skip font rendering tests on Fuchsia
flar Jun 27, 2021
a160d27
fix signed size_t comparisons causing vector overflow
flar Jun 27, 2021
b578935
eliminate another unsigned size_t comparison in a unit test
flar Jun 27, 2021
cc83cf5
more review feedback
flar Jun 28, 2021
bd50c5c
add drawImageLattice tests and more style guide renames
flar Jun 29, 2021
4a79eef
remove all ShadowRec code and leave a few comments pointing to the re…
flar Jun 30, 2021
0d66114
switch DL off by default and move some EXPECT_DEATH tests inside DEBU…
flar Jun 30, 2021
3755bf1
adjust new DL sources for recent removal of Fuchsia legacy code
flar Jun 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ci/licenses_golden/licenses_flutter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@ FILE: ../../../flutter/flow/compositor_context.cc
FILE: ../../../flutter/flow/compositor_context.h
FILE: ../../../flutter/flow/diff_context.cc
FILE: ../../../flutter/flow/diff_context.h
FILE: ../../../flutter/flow/display_list.cc
FILE: ../../../flutter/flow/display_list.h
FILE: ../../../flutter/flow/display_list_canvas.cc
FILE: ../../../flutter/flow/display_list_canvas.h
FILE: ../../../flutter/flow/display_list_canvas_unittests.cc
FILE: ../../../flutter/flow/display_list_unittests.cc
FILE: ../../../flutter/flow/display_list_utils.cc
FILE: ../../../flutter/flow/display_list_utils.h
FILE: ../../../flutter/flow/embedded_view_params_unittests.cc
FILE: ../../../flutter/flow/embedded_views.cc
FILE: ../../../flutter/flow/embedded_views.h
Expand Down Expand Up @@ -67,6 +75,9 @@ FILE: ../../../flutter/flow/layers/color_filter_layer_unittests.cc
FILE: ../../../flutter/flow/layers/container_layer.cc
FILE: ../../../flutter/flow/layers/container_layer.h
FILE: ../../../flutter/flow/layers/container_layer_unittests.cc
FILE: ../../../flutter/flow/layers/display_list_layer.cc
FILE: ../../../flutter/flow/layers/display_list_layer.h
FILE: ../../../flutter/flow/layers/display_list_layer_unittests.cc
FILE: ../../../flutter/flow/layers/image_filter_layer.cc
FILE: ../../../flutter/flow/layers/image_filter_layer.h
FILE: ../../../flutter/flow/layers/image_filter_layer_unittests.cc
Expand Down
3 changes: 3 additions & 0 deletions common/settings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,9 @@ struct Settings {
// Selects the SkParagraph implementation of the text layout engine.
bool enable_skparagraph = false;

// Selects the DisplayList for storage of rendering operations.
bool enable_display_list = false;

// All shells in the process share the same VM. The last shell to shutdown
// should typically shut down the VM as well. However, applications depend on
// the behavior of "warming-up" the VM by creating a shell that does not do
Expand Down
11 changes: 11 additions & 0 deletions flow/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ source_set("flow") {
"compositor_context.h",
"diff_context.cc",
"diff_context.h",
"display_list.cc",
Copy link
Member

@chinmaygarde chinmaygarde Jun 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: Can we put the ops in their own header? The stuff about the display list is way more interesting that the op definitions. Will just make the code a bit easier to navigate.

Copy link
Contributor Author

@flar flar Jun 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently they are private to that cc file. Their definitions aren't needed anywhere else.

Basically display_list.[h,cc] exist only to define, pack, and unpack the structure through Dispatcher. Everything else is in a different file.

Copy link
Contributor Author

@flar flar Jun 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll lump this in with the previous suggestions for using a manifest and for investigating alternate storage solutions.

"display_list.h",
"display_list_canvas.cc",
"display_list_canvas.h",
"display_list_utils.cc",
"display_list_utils.h",
"embedded_views.cc",
"embedded_views.h",
"frame_timings.cc",
Expand All @@ -30,6 +36,8 @@ source_set("flow") {
"layers/color_filter_layer.h",
"layers/container_layer.cc",
"layers/container_layer.h",
"layers/display_list_layer.cc",
"layers/display_list_layer.h",
"layers/image_filter_layer.cc",
"layers/image_filter_layer.h",
"layers/layer.cc",
Expand Down Expand Up @@ -123,6 +131,8 @@ if (enable_unittests) {
testonly = true

sources = [
"display_list_canvas_unittests.cc",
"display_list_unittests.cc",
"embedded_view_params_unittests.cc",
"flow_run_all_unittests.cc",
"flow_test_utils.cc",
Expand All @@ -136,6 +146,7 @@ if (enable_unittests) {
"layers/clip_rrect_layer_unittests.cc",
"layers/color_filter_layer_unittests.cc",
"layers/container_layer_unittests.cc",
"layers/display_list_layer_unittests.cc",
"layers/image_filter_layer_unittests.cc",
"layers/layer_tree_unittests.cc",
"layers/opacity_layer_unittests.cc",
Expand Down
Loading