This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland ios accessibility scrolling support #26860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunhtai
force-pushed
the
issues/80711-reland-again
branch
from
51bbd24 to
fcb0f56
Compare
gaaclarke
approved these changes
Jun 23, 2021
Member
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
lgtm, i was hoping that the move to isfinite would handle nan for you, guess not.
|
|
||
| - (float)scrollExtentMax { | ||
| if (![_semanticsObject isAccessibilityBridgeAlive]) { | ||
| return 0.0; |
chunhtai
force-pushed
the
issues/80711-reland-again
branch
2 times, most recently
from
7ddc62f to
86e8a00
Compare
chunhtai
force-pushed
the
issues/80711-reland-again
branch
from
86e8a00 to
817743b
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 24, 2021
moffatman
pushed a commit
to moffatman/engine
that referenced
this pull request
Aug 5, 2021
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous pr is causing internal test failure. The issue is due to the scroll extend and scroll position can be NaN.
The fix is in the second commit
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.