Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@knopp
Copy link
Member

@knopp knopp commented May 13, 2021

Fixes flutter/flutter#82353

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label May 13, 2021
@knopp knopp force-pushed the remove_layer_trees_from_pipeline branch 2 times, most recently from 4ad6c63 to 80f4b9c Compare May 16, 2021 09:53
@knopp knopp force-pushed the remove_layer_trees_from_pipeline branch from 80f4b9c to 7835587 Compare May 16, 2021 10:58
@knopp knopp changed the title Remove layer trees from pipeline when destroying Animator WIP: Remove layer trees from pipeline when destroying Animator May 16, 2021
@knopp

This comment has been minimized.

@knopp knopp changed the title WIP: Remove layer trees from pipeline when destroying Animator Remove layer trees from pipeline when destroying Animator May 17, 2021
@knopp
Copy link
Member Author

knopp commented May 18, 2021

Closing in favor of #26210.

@knopp knopp closed this May 18, 2021
@knopp knopp deleted the remove_layer_trees_from_pipeline branch July 17, 2021 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion in ~SkiaUnrefQueue()

1 participant