This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Allow embedders to set a custom log tag #25435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Embedders making use of the embedder API always ended up with a hardcoded log tag of "flutter". Some embedders may wish to set a different log tag. For example, the Fuchsia embedder sets their log tag to a launch URL followed by "flutter". If unset, we continue to default to "flutter". Fixes flutter/flutter#79819
chinmaygarde
approved these changes
Apr 5, 2021
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
I could have sworn that this was already possible and looked up how I had done this in the past. Turns out, I was passing --log-tag= in via the command line args. This makes more sense.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 6, 2021
flar
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 6, 2021
* 1d8d2df Rename EngineEmbedderApiModifier to EngineModifier (flutter/engine#25362) * 057ed22 Roll Skia from b14a819122ee to 0a12b85f160f (5 revisions) (flutter/engine#25430) * 079857d Roll Fuchsia Linux SDK from b22xnKMfp... to txu1APnex... (flutter/engine#25431) * 23ac479 Extract Dart logging to the embedders (flutter/engine#25402) * 5444e2b Remove the DartIsolate::PostMessage timeline event (flutter/engine#25433) * 253a298 Roll Skia from 0a12b85f160f to 974c82150204 (1 revision) (flutter/engine#25434) * 61dca0f Roll Dart SDK from c274ba72ec73 to 3dd1630ab4d4 (1 revision) (flutter/engine#25432) * f09b189 Allow embedders to set a custom log tag (flutter/engine#25435) * e74b649 Roll Fuchsia Mac SDK from F4eUNa2mh... to IKx9cvrtJ... (flutter/engine#25436)
duanqz
pushed a commit
to duanqz/engine
that referenced
this pull request
Apr 16, 2021
Embedders making use of the embedder API always ended up with a hardcoded log tag of "flutter". Some embedders may wish to set a different log tag. For example, the Fuchsia embedder sets their log tag to a launch URL followed by "flutter". If unset, we continue to default to "flutter". Fixes flutter/flutter#79819
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embedders making use of the embedder API always ended up with a
hardcoded log tag of "flutter". Some embedders may wish to set a
different log tag. For example, the Fuchsia embedder sets its log tag
to a launch URL followed by "flutter".
If unspecified, we continue to default to "flutter".
Fixes flutter/flutter#79819
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.