[fuchsia] Use scenic allocator service #25385
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| sysmem_allocator_->SetDebugClientInfo(GetCurrentProcessName(), | ||
| GetCurrentProcessId()); | ||
| FML_DCHECK(status != ZX_OK); | ||
| status = fdio_service_connect( |
There was a problem hiding this comment.
Ah, I need to plumb these through the ComponentContext....will do in another CL
|
@arbreng The test failure looks relevant to the patch. Can we update this patch? |
That failure is expected until flutter engine is using a version of Fuchsia that includes https://fuchsia.googlesource.com/fuchsia/+/d7e580eb8060fcdc3e6941298dc143518ddb6d74 for these tests. How can I tell what version of Fuchsia is used for these tests? |
Switch to scenic allocator and Image3 API.
dreveman
force-pushed
the
scenic-allocation
branch
from
c6e55c1 to
7dd8083
Compare
…ter#25655) This reverts commit 8c14250.
…5663) This reverts commit 8c14250. Co-authored-by: David Worsham <[email protected]>
Switch to scenic allocator and Image3 API. Co-authored-by: David Reveman <[email protected]>
…ter#25655) This reverts commit 8c14250.
4 participants
Switch to scenic allocator and Image3 API.