Sync analyzer_options.yaml #25129
Sync analyzer_options.yaml #25129
Conversation
goderbauer
force-pushed
the
lintsync
branch
2 times, most recently
from
c588162 to
f243ecc
Compare
|
I guess if the tests pass then things are okay, but removing some of those |
|
@zanderso I believe removing those awaits shouldn't change anything. It is is only removing awaits from Futures that are directly returned from methods. Either those methods are awaited on the other side (which means the Future is still awaited) or they are not awaited there and in that case the await within the method shouldn't make a difference. All tests (except for the unrelated failure tracked in flutter/flutter#78804) seem to be passing. |
goderbauer
added
the
waiting for tree to go green
|
Does this fix the analyzer_options failure seen in https://github.com/flutter/flutter/pull/78900/checks?check_run_id=2182989685 ? |
|
Also, https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8851920400027736576/+/steps/run_test.dart_for_web_tests_shard_and_subshard_0/0/stdout began failing after this PR, unclear if it is responsible at a glance. |
4 participants
No description provided.