Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Add few awaits in history tests #24934

Merged
merged 2 commits into from
Mar 10, 2021
Merged

[web] Add few awaits in history tests #24934

merged 2 commits into from
Mar 10, 2021

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Mar 10, 2021

History-related tests have been failing in LUCI but not when run locally. This could be a race condition somewhere. Example failures:

  1. https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Web%20Engine/4218/overview
  2. https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Web%20Engine/4219/overview

In an attempt to address the race condition, this PR adds a few missing awaits in a few places that are doing asynchronous work.

@mdebbar mdebbar added affects: tests platform-web Code specifically for the web engine labels Mar 10, 2021
@mdebbar mdebbar requested a review from jason-simmons March 10, 2021 22:28
@google-cla google-cla bot added the cla: yes label Mar 10, 2021
@mdebbar mdebbar requested a review from yjbanov March 10, 2021 22:28
yjbanov
yjbanov approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdebbar mdebbar added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 10, 2021
@fluttergithubbot fluttergithubbot merged commit 21a484d into flutter:master Mar 10, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2021
@engine-flutter-autoroll
21a484d [web] Add few awaits in history tests (flutter/engine#24934)
36ea3a2
@yjbanov
Copy link
Contributor

yjbanov commented Mar 11, 2021

Heads up, the test failed again after I rebased my PR on top of this change: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8853078969538143168/+/steps/felt_test:_chrome-unit-linux/0/stdout

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2021
@engine-flutter-autoroll
21a484d [web] Add few awaits in history tests (flutter/engine#24934)
c49251b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2021
@engine-flutter-autoroll
21a484d [web] Add few awaits in history tests (flutter/engine#24934)
462c010
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2021
@engine-flutter-autoroll
21a484d [web] Add few awaits in history tests (flutter/engine#24934)
56c1a22
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2021
@engine-flutter-autoroll
21a484d [web] Add few awaits in history tests (flutter/engine#24934)
63398c9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2021
@engine-flutter-autoroll
21a484d [web] Add few awaits in history tests (flutter/engine#24934)
64e57ee
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2021
@engine-flutter-autoroll
21a484d [web] Add few awaits in history tests (flutter/engine#24934)
4d945aa
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2021
@engine-flutter-autoroll
21a484d [web] Add few awaits in history tests (flutter/engine#24934)
cea54d2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2021
@engine-flutter-autoroll
21a484d [web] Add few awaits in history tests (flutter/engine#24934)
91086e5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2021
@engine-flutter-autoroll
21a484d [web] Add few awaits in history tests (flutter/engine#24934)
e459def
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2021
@engine-flutter-autoroll
21a484d [web] Add few awaits in history tests (flutter/engine#24934)
801492e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2021
@engine-flutter-autoroll
21a484d [web] Add few awaits in history tests (flutter/engine#24934)
6b995c0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2021
@engine-flutter-autoroll
21a484d [web] Add few awaits in history tests (flutter/engine#24934)
a3337fa
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2021
@engine-flutter-autoroll
21a484d [web] Add few awaits in history tests (flutter/engine#24934)
04363de
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2021
@engine-flutter-autoroll
21a484d [web] Add few awaits in history tests (flutter/engine#24934)
b9a61b2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2021
@engine-flutter-autoroll
21a484d [web] Add few awaits in history tests (flutter/engine#24934)
27ad197
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2021
@engine-flutter-autoroll
21a484d [web] Add few awaits in history tests (flutter/engine#24934)
788a84c
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@mdebbar @hjfreyer
[web] Add few awaits in history tests (flutter#24934)
0218df0
chriscraws pushed a commit to chriscraws/engine that referenced this pull request Mar 23, 2021
@mdebbar @chriscraws
[web] Add few awaits in history tests (flutter#24934)
cb649e8
@mdebbar mdebbar deleted the await_history branch April 15, 2021 17:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jason-simmons jason-simmons Awaiting requested review from jason-simmons

1 more reviewer

@yjbanov yjbanov yjbanov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

affects: tests cla: yes platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdebbar @yjbanov @fluttergithubbot