This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Detach the newly created EGL context from the main thread in the embedder unit tests #24908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dder unit tests The EGL context will be used by other threads during test execution, and it should not be active on multiple threads at the same time. This was not noticed previously because SwiftShader was not checking for this, but other EGL implementations may enforce this constraint.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
cbracken
approved these changes
Mar 10, 2021
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
Thanks. This fell off my back-burner on Friday.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 10, 2021
…the embedder unit tests (flutter/engine#24908)
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
…dder unit tests (flutter#24908) The EGL context will be used by other threads during test execution, and it should not be active on multiple threads at the same time. This was not noticed previously because SwiftShader was not checking for this, but other EGL implementations may enforce this constraint.
chriscraws
pushed a commit
to chriscraws/engine
that referenced
this pull request
Mar 23, 2021
…dder unit tests (flutter#24908) The EGL context will be used by other threads during test execution, and it should not be active on multiple threads at the same time. This was not noticed previously because SwiftShader was not checking for this, but other EGL implementations may enforce this constraint.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EGL context will be used by other threads during test execution, and it
should not be active on multiple threads at the same time. This was not
noticed previously because SwiftShader was not checking for this, but other
EGL implementations may enforce this constraint.