Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Mar 8, 2021

Initially landed in: #24798
Reverted in: #24870

Previously caused failures in framework tests. This PR is exactly the same as the reverted PR with only one additional commit to fix framework tests: 5a071c7

Fixes flutter/flutter#75987

@mdebbar mdebbar added the platform-web Code specifically for the web engine label Mar 8, 2021
@mdebbar mdebbar requested a review from cbracken March 8, 2021 21:15
@google-cla google-cla bot added the cla: yes label Mar 8, 2021
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdebbar mdebbar added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 9, 2021
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows Web Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[web] PlatformRouteInformationProvider does not change browser's URL

3 participants