-
Notifications
You must be signed in to change notification settings - Fork 6k
Adds setText to web engine #24873
Adds setText to web engine #24873
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
The test will be on the framework side, the test will pass once this engine change is in https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8853304046211326768/+/steps/run_test.dart_for_web_tests_shard_and_subshard_4/0/stdout |
justinmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
| case _kSetText: | ||
| return 'SemanticsAction.setText'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @yjbanov
The previous pr forgot to add the setText to other part of the web engine. this pr fixes it
related flutter/flutter#77271
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.