Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@huanghongxun
Copy link
Contributor

@huanghongxun huanghongxun commented Mar 8, 2021

This PR fixes #76881.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Mar 8, 2021
@huanghongxun
Copy link
Contributor Author

huanghongxun commented Mar 8, 2021

This pull request fixes embedder complains about render target creation failure.
Please note that this patch only fixes incorrect texture format. After applying this patch, the Flutter window unexpectedly whitens, which I have no idea for fixing.
@robert-ancell @wmww

@huanghongxun
Copy link
Contributor Author

huanghongxun commented Mar 10, 2021

@chinmaygarde I want to know why embedder uses a platform-dependent texture color type instead of a certain value (e.g. RGBA8888). Linux shell must decide texture format according to platform(CPU endian according to skia GrGLCaps.cpp) instead of settings a certain value(e.g. GL_RGBA8), which results in duplicated code with Skia or importing Skia headers.

kN32_SkColorType, // color type

Changing above constant to kRGBA_8888_SkColorType will result in a simpler solution in Linux shell.

@huanghongxun huanghongxun changed the title Fix incorrect texture format with OpenGL ES [Linux] Fix incorrect texture format with OpenGL ES Mar 11, 2021
Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @huanghongxun!

@robert-ancell robert-ancell merged commit f104bad into flutter:master Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Linux] [regression] Apps won't start under "OpenGL ES" - CRASH ( Could not wrap embedder supplied frame-buffer )

3 participants