Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@clarkezone
Copy link

@clarkezone clarkezone commented Mar 8, 2021

This change switches the Windows UWP build from shipped cppwinrt headers to headers generated by the cppwinrt tool.

  • Fix support for the latest Windows SDK (10.0.19041.0) by generating winrt SDK headers from SDK metadata rather than using shipped headers which have clang compatibility bugs. SDK metadata is the source of truth for the WinRT ABI; by using the latest tool rather than shipped headers, most recent compatibility fixes can be picked up on an ongoing basis.

Depends on flutter/buildroot#442

flutter/flutter#70205
flutter/flutter#14967

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@clarkezone clarkezone requested a review from cbracken March 8, 2021 05:01
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Mar 8, 2021
@clarkezone clarkezone changed the title Switch build to using winrt generated headers Windows: Switch UWP build to using winrt generated headers Mar 8, 2021
@clarkezone clarkezone self-assigned this Mar 10, 2021
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Dependent patch flutter/buildroot#442 needs a quick fix then the annotated buildroot roll before landing.

@chinmaygarde
Copy link
Member

The dependent patch looks good to me after @clarkezone addressed @cbracken s comments on it. I believe this patch is unblocked. Lets land it soon (after fixing the DEPS entry of course 😄 )

@clarkezone
Copy link
Author

Thx, I'll land both this evening

@cbracken
Copy link
Member

cbracken commented Mar 12, 2021

Kicked build_and_test_linux_unopt_debug. Re-run: https://cirrus-ci.com/task/4666251248140288. Flake report filed.

@cbracken
Copy link
Member

Looks like it hung on ShellTest.SkipAndSubmitFrame.

[ RUN      ] ShellTest.SkipAndSubmitFrame
[FATAL:flutter/testing/test_timeout_listener.cc(45)] Check failed: delay < timeout_. Test ShellTest.SkipAndSubmitFrame did not complete in 30 seconds and is assumed to be hung. Killing the test harness.

Filed another flake.

@cbracken cbracken merged commit 57a401a into flutter:master Mar 12, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2021
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
…4861)

* Switch build to using generated headers

* Update DEPS to pick up newer buildroot

* Only run hook on Windows
chriscraws pushed a commit to chriscraws/engine that referenced this pull request Mar 23, 2021
…4861)

* Switch build to using generated headers

* Update DEPS to pick up newer buildroot

* Only run hook on Windows
duanqz pushed a commit to duanqz/engine that referenced this pull request Apr 16, 2021
…4861)

* Switch build to using generated headers

* Update DEPS to pick up newer buildroot

* Only run hook on Windows
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants