-
Notifications
You must be signed in to change notification settings - Fork 6k
Windows: Switch UWP build to using winrt generated headers #24861
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
cbracken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Dependent patch flutter/buildroot#442 needs a quick fix then the annotated buildroot roll before landing.
|
The dependent patch looks good to me after @clarkezone addressed @cbracken s comments on it. I believe this patch is unblocked. Lets land it soon (after fixing the DEPS entry of course 😄 ) |
|
Thx, I'll land both this evening |
|
Kicked build_and_test_linux_unopt_debug. Re-run: https://cirrus-ci.com/task/4666251248140288. Flake report filed. |
|
Looks like it hung on Filed another flake. |
…4861) * Switch build to using generated headers * Update DEPS to pick up newer buildroot * Only run hook on Windows
…4861) * Switch build to using generated headers * Update DEPS to pick up newer buildroot * Only run hook on Windows
…4861) * Switch build to using generated headers * Update DEPS to pick up newer buildroot * Only run hook on Windows
This change switches the Windows UWP build from shipped cppwinrt headers to headers generated by the cppwinrt tool.
Depends on flutter/buildroot#442
flutter/flutter#70205
flutter/flutter#14967
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.