Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Don't set both color and foreground at the same time #24828

Merged
merged 1 commit into from
Mar 6, 2021
Merged

[web] Don't set both color and foreground at the same time #24828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/web_ui/lib/src/engine/text/canvas_paragraph.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ abstract class StyleNode {
return style;
}

ui.Color get _color;
ui.Color? get _color;
ui.TextDecoration? get _decoration;
ui.Color? get _decorationColor;
ui.TextDecorationStyle? get _decorationStyle;
Expand Down Expand Up @@ -439,7 +439,7 @@ class ChildStyleNode extends StyleNode {
// property isn't defined, go to the parent node.

@override
ui.Color get _color => style._color ?? parent._color;
ui.Color? get _color => style._color ?? (_foreground == null ? parent._color : null);

@override
ui.TextDecoration? get _decoration => style._decoration ?? parent._decoration;
Expand Down