This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Replace Flutter surface only after all platform views are destroyed" #24800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
The issue seems to be that on the C++ side, the threads are unmerged causing the GL context to change. |
jason-simmons
approved these changes
Mar 5, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 5, 2021
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
…troyed (flutter#24363)" (flutter#24800) This reverts commit 1dc8695.
chriscraws
pushed a commit
to chriscraws/engine
that referenced
this pull request
Mar 23, 2021
…troyed (flutter#24363)" (flutter#24800) This reverts commit 1dc8695.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until https://b.corp.google.com/issues/181010760 is resolved.
Reverts #24363