This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "TextStyle level leadingDistribution (#24025)" reverted in #24665 #24668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in flutter#24665 This reverts commit 6191270.
| bitmask |= (forceStrutHeight ? 1 : 0) << 8; | ||
| } | ||
|
|
||
| data.setInt8(0, bitmask); |
Member
There was a problem hiding this comment.
This will need to be expanded to setInt16 now that there are more than 8 flag bits.
The initialization of byteCount at the beginning of _encodeStrut will also change to 2 to match the width of the bit mask.
Contributor
Author
There was a problem hiding this comment.
squeezed forceStrutHeight into 1 bit by treating null as false.
lib/ui/text.dart
Outdated
| byteCount += 4; | ||
| if (leadingDistribution != null) { | ||
| bitmask |= 1 << 5; | ||
| data.setInt8(byteCount, leadingDistribution.index); |
Member
There was a problem hiding this comment.
This does not match the logic in decodeStrut.
decodeStrut assumes that all the float fields are placed after the byte fields in the buffer. But _encodeStrut is placing the leadingDistribution byte after the height float.
Also, the byteCount += 4 here does not match the setInt8, and it could exceed the size of the ByteData buffer.
I'd recommend moving the encoding of this field up so that it precedes the float fields.
LongCatIsLooong
force-pushed
the
reland-24665
branch
from
359ee48 to
ceb683d
Compare
LongCatIsLooong
force-pushed
the
reland-24665
branch
from
ceb683d to
3765e9a
Compare
Contributor
Author
|
Diff: 3765e9a. Still have some Scuba failures but line spacing looks correct now. |
LongCatIsLooong
force-pushed
the
reland-24665
branch
from
24777d6 to
c9fd43e
Compare
8 tasks
jason-simmons
approved these changes
Mar 1, 2021
LongCatIsLooong
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 2, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 2, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 2, 2021
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
chriscraws
pushed a commit
to chriscraws/engine
that referenced
this pull request
Mar 23, 2021
pull bot
pushed a commit
to Mu-L/skia
that referenced
this pull request
Apr 16, 2021
Change-Id: I5627cb163400880992db622bb887093da92d1cd5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/394969 Commit-Queue: Julia Lavrova <[email protected]> Reviewed-by: Julia Lavrova <[email protected]>
skia-flutter-autoroll
added a commit
to skia-flutter-autoroll/engine
that referenced
this pull request
Apr 16, 2021
https://skia.googlesource.com/skia.git/+log/e2b457ad5fab..624a529fbd01 2021-04-16 [email protected] Added an API for creating RuntimeEffects using the SkSL DSL. 2021-04-16 [email protected] Generalize the squircle runtime effect to draw "super rounded rects" 2021-04-16 [email protected] Viewer: apply same transform as slide to dimensions display. 2021-04-16 [email protected] Lower GPU budget to 16MB on some desktop bots 2021-04-16 [email protected] Add halfLeading to TextStyle and StrutStyle: flutter#24668 2021-04-16 [email protected] Fix android framework build in GrVkOpsRenderPass. 2021-04-16 [email protected] Incorporate top-level DSL blocks into fragment processors. 2021-04-16 [email protected] Fix gm dimensions 2021-04-16 [email protected] Use GrVkFramebuffer throughout GrVkOpsRenderPass instead of GrVkRT. 2021-04-16 [email protected] Fix gpuResourceCacheLimit implementation 2021-04-16 [email protected] Expose experimental iterator on SkParagraph If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
JiaLiangAl
pushed a commit
to JiaLiangAl/chromium
that referenced
this pull request
Apr 17, 2021
https://skia.googlesource.com/skia.git/+log/da34d099fcab..624a529fbd01 2021-04-16 [email protected] Added an API for creating RuntimeEffects using the SkSL DSL. 2021-04-16 [email protected] Generalize the squircle runtime effect to draw "super rounded rects" 2021-04-16 [email protected] Viewer: apply same transform as slide to dimensions display. 2021-04-16 [email protected] Lower GPU budget to 16MB on some desktop bots 2021-04-16 [email protected] Add halfLeading to TextStyle and StrutStyle: flutter/engine#24668 2021-04-16 [email protected] Fix android framework build in GrVkOpsRenderPass. 2021-04-16 [email protected] Incorporate top-level DSL blocks into fragment processors. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: [email protected] Change-Id: Ia1da5744a7ce10c5d20dfa08238ffe909ec81950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2830208 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/master@{#873514}
romanzes
pushed a commit
to romanzes/skia
that referenced
this pull request
Nov 22, 2021
Change-Id: I5627cb163400880992db622bb887093da92d1cd5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/394969 Commit-Queue: Julia Lavrova <[email protected]> Reviewed-by: Julia Lavrova <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6191270.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.