Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Restore call to setFilterQuality #24542

Merged
merged 2 commits into from
Feb 22, 2021
Merged

Restore call to setFilterQuality #24542

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adf83b4
Restore call to setFilterQuality
reed-at-google Feb 21, 2021
3bc2a77
fix formatting
reed-at-google Feb 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/ui/painting/paint.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@ Paint::Paint(Dart_Handle paint_objects, Dart_Handle paint_data) {
const uint32_t* uint_data = static_cast<const uint32_t*>(byte_data.data());
const float* float_data = static_cast<const float*>(byte_data.data());

auto filter_quality =
static_cast<SkFilterQuality>(uint_data[kFilterQualityIndex]);

Dart_Handle values[kObjectCount];
if (!Dart_IsNull(paint_objects)) {
FML_DCHECK(Dart_IsList(paint_objects));
Expand All @@ -92,9 +95,7 @@ Paint::Paint(Dart_Handle paint_objects, Dart_Handle paint_data) {
Dart_Handle shader = values[kShaderIndex];
if (!Dart_IsNull(shader)) {
Shader* decoded = tonic::DartConverter<Shader*>::FromDart(shader);
uint32_t filter_quality = uint_data[kFilterQualityIndex];
paint_.setShader(
decoded->shader(static_cast<SkFilterQuality>(filter_quality)));
paint_.setShader(decoded->shader(filter_quality));
}

Dart_Handle color_filter = values[kColorFilterIndex];
Expand All @@ -113,6 +114,7 @@ Paint::Paint(Dart_Handle paint_objects, Dart_Handle paint_data) {
}

paint_.setAntiAlias(uint_data[kIsAntiAliasIndex] == 0);
paint_.setFilterQuality(filter_quality);

uint32_t encoded_color = uint_data[kColorIndex];
if (encoded_color) {
Expand Down