Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@renyou
Copy link
Contributor

@renyou renyou commented Feb 18, 2021

Cherrypick to for an internal individual roll.

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link

@pcsosinski pcsosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

@chinmaygarde
Copy link
Member

Is this something we are going to land? @jason-simmons says this is to make a roll easier.

@renyou
Copy link
Contributor Author

renyou commented Feb 18, 2021

Is this something we are going to land? @jason-simmons says this is to make a roll easier.

Yes. This PR has already landed on master branch. It causes many golden changes internally. I am creating this branch so we can roll this PR into internal code base by itself.

@renyou renyou merged commit c53a160 into flutter:flutter-1.27-candidate.7 Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants