This repository was archived by the owner on Feb 25, 2025. It is now read-only.
fix missing CJK and symbol glyphs, font precedence, fallback reset #24470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
added a commit
to yjbanov/goldens
that referenced
this pull request
Feb 18, 2021
yjbanov
force-pushed
the
missing-cjk-chars
branch
from
23d34f3 to
84c18ff
Compare
harryterkelsen
approved these changes
Feb 19, 2021
| // TODO(yjbanov): instead of mutating the font tree during reset, it's | ||
| // better to construct an immutable tree of resolved fonts | ||
| // pointing back to the original NotoFont objects. Then | ||
| // resetting the tree would be a matter of reconstrucint |
Contributor
There was a problem hiding this comment.
nit: reconstructing
| await font.ensureResolved(); | ||
| } | ||
|
|
||
| final Set<int> unmatchedCodeUnits = Set<int>.from(coveredCodeUnits); |
Contributor
There was a problem hiding this comment.
this was confusing initially. maybe comment that it doesn't actually become "unmatchedCodeUnits" until it is passed as an input to findMInimumFontsForCodeUnits
| } | ||
|
|
||
| if (rangesMap.isEmpty) { | ||
| html.window.console.warn('Parses Google Fonts CSS was empty: $css'); |
yjbanov
force-pushed
the
missing-cjk-chars
branch
from
84c18ff to
271e4d0
Compare
yjbanov
added a commit
to yjbanov/goldens
that referenced
this pull request
Feb 19, 2021
yjbanov
added a commit
to flutter/goldens
that referenced
this pull request
Feb 19, 2021
* golden updates for flutter/engine#24470 * add internation text samples
yjbanov
force-pushed
the
missing-cjk-chars
branch
from
0d6b0ce to
59cdd0d
Compare
Contributor
Author
|
LUCI failure is a network flake. Submitting and will keep an eye on LUCI. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 22, 2021
christopherfujino
added a commit
that referenced
this pull request
Feb 23, 2021
…24557) * Update Dart to 2.12.0-259.15.beta * Propagate image decode errors to the future returned by Codec.getNextFrame (#24336) * fix infinite loop in findMinimumFontsForCodeunits (#24441) * Roll CanvasKit to 0.24. (#24498) * Update tests for new API * Update goldens and respond to comment * fix missing CJK and symbol glyphs, font precedence, fallback reset (#24470) * fix missing CJK and symbol glyphs * Cache known covered code units Co-authored-by: Harry Terkelsen <[email protected]> * Update licenses_golden Co-authored-by: Jason Simmons <[email protected]> Co-authored-by: Yegor <[email protected]> Co-authored-by: Harry Terkelsen <[email protected]> Co-authored-by: Harry Terkelsen <[email protected]>
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
…lutter#24470) * fix missing CJK and symbol glyphs * Cache known covered code units Co-authored-by: Harry Terkelsen <[email protected]>
chriscraws
pushed a commit
to chriscraws/engine
that referenced
this pull request
Mar 23, 2021
…lutter#24470) * fix missing CJK and symbol glyphs * Cache known covered code units Co-authored-by: Harry Terkelsen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes flutter/flutter#73628. This still needs @hterkelsen's CanvasKit 0.23 PR to reland.