Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Roll CanvasKit to 0.23 #24249

Merged
merged 9 commits into from
Feb 16, 2021
Merged

Roll CanvasKit to 0.23 #24249

merged 9 commits into from
Feb 16, 2021

Conversation

@harryterkelsen
Copy link
Contributor

@harryterkelsen harryterkelsen commented Feb 5, 2021

Rolls CanvasKit to 0.23.

Fixes flutter/flutter#74742

Goldens update: flutter/goldens#158

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 5, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

yjbanov
yjbanov approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdebbar mdebbar mentioned this pull request Feb 10, 2021
Closed
@chinmaygarde chinmaygarde added the platform-web Code specifically for the web engine label Feb 11, 2021
@yjbanov yjbanov mentioned this pull request Feb 16, 2021
Closed
@harryterkelsen harryterkelsen merged commit afe6cce into flutter:master Feb 16, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2021
@engine-flutter-autoroll
afe6cce Roll CanvasKit to 0.23 (flutter/engine#24249)
a6863eb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2021
@engine-flutter-autoroll
afe6cce Roll CanvasKit to 0.23 (flutter/engine#24249)
3d53599
@zanderso zanderso mentioned this pull request Feb 17, 2021
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2021
@engine-flutter-autoroll
afe6cce Roll CanvasKit to 0.23 (flutter/engine#24249)
50e0f08
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2021
@engine-flutter-autoroll
afe6cce Roll CanvasKit to 0.23 (flutter/engine#24249)
4ffe393
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2021
@engine-flutter-autoroll
afe6cce Roll CanvasKit to 0.23 (flutter/engine#24249)
942abd8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2021
@engine-flutter-autoroll
afe6cce Roll CanvasKit to 0.23 (flutter/engine#24249)
8f607b1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
afe6cce Roll CanvasKit to 0.23 (flutter/engine#24249)
62eeebd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
afe6cce Roll CanvasKit to 0.23 (flutter/engine#24249)
ddaaf15
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
afe6cce Roll CanvasKit to 0.23 (flutter/engine#24249)
466e945
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
afe6cce Roll CanvasKit to 0.23 (flutter/engine#24249)
5a4c0ab
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
afe6cce Roll CanvasKit to 0.23 (flutter/engine#24249)
656cbe7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
afe6cce Roll CanvasKit to 0.23 (flutter/engine#24249)
219b87a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
afe6cce Roll CanvasKit to 0.23 (flutter/engine#24249)
4067b23
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
afe6cce Roll CanvasKit to 0.23 (flutter/engine#24249)
43c563f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
afe6cce Roll CanvasKit to 0.23 (flutter/engine#24249)
cd29910
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
afe6cce Roll CanvasKit to 0.23 (flutter/engine#24249)
dd6f40a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
afe6cce Roll CanvasKit to 0.23 (flutter/engine#24249)
959566d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
afe6cce Roll CanvasKit to 0.23 (flutter/engine#24249)
5c3473d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
afe6cce Roll CanvasKit to 0.23 (flutter/engine#24249)
8f9dc8d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
afe6cce Roll CanvasKit to 0.23 (flutter/engine#24249)
55c6c37
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
afe6cce Roll CanvasKit to 0.23 (flutter/engine#24249)
13934d1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
afe6cce Roll CanvasKit to 0.23 (flutter/engine#24249)
fcd597c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
afe6cce Roll CanvasKit to 0.23 (flutter/engine#24249)
dac2c40
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@hjfreyer
Roll CanvasKit to 0.23 (flutter#24249)
6a31afd
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@hjfreyer
Revert "Roll CanvasKit to 0.23" (flutter#24461)
048572e 
* Revert "Roll CanvasKit to 0.23 (flutter#24249)"

This reverts commit afe6cce.

* Update goldens to reverted master
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@yjbanov yjbanov yjbanov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-web Code specifically for the web engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[canvaskit] spaces appear as crossed out boxes in CJK text

4 participants

@harryterkelsen @yjbanov @chinmaygarde @googlebot