This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
ci: Print output in case of compile error #23522
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jan 14, 2021
Member
|
I think the presubmit failure is a known flake that has been fixed. I have re-run it but I can't recall if it required a rebase as well. If the CQ fails after the test run still, please rebase and land. Thanks. |
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 20, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 20, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 20, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 20, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 20, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 20, 2021
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 20, 2021
* d4a7358 Roll Dart SDK from c4214e6daaac to 4a6764bf28c2 (4 revisions) (flutter/engine#23770) * 9bc776a [web] Add --watch flag to 'felt test' (flutter/engine#23727) * 247ebc2 Roll Skia from bde06cc511d2 to f3087d8297fe (7 revisions) (flutter/engine#23772) * 8b27e6f skip flaky test (flutter/engine#23775) * 2927e9f block thread merging with shared engines (flutter/engine#23733) * df5f3b0 Implement handling of framework-handled key events (flutter/engine#23655) * f205ced Roll Skia from f3087d8297fe to e0fe62adaa3e (9 revisions) (flutter/engine#23781) * fa7aebf Roll Skia from e0fe62adaa3e to 18aeb5731b51 (1 revision) (flutter/engine#23784) * 9acfb7d Fix JNI void vs object method call (flutter/engine#23785) * df13ccf Roll Skia from 18aeb5731b51 to 7aa7f039b9ee (1 revision) (flutter/engine#23786) * e3e3b2b Roll Fuchsia Mac SDK from pc_veLlry... to xYraItnQp... (flutter/engine#23787) * 8a096d6 ci: Print output in case of compile error (flutter/engine#23522) * f1c3ced Roll Fuchsia Linux SDK from fByXAJ76e... to vs54lOVoj... (flutter/engine#23788) * 0c79393 Revert "Roll Dart SDK from c4214e6daaac to 4a6764bf28c2 (4 revisions) (#23770)" (flutter/engine#23791)
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
* Print compile error * Better comment * Update run_tests.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR prints the
CalledProcessError.outputbefore the error is thrown and crashes the app. This happens when the test fails to compile. Without it, you only get the following message and will never know where to fix without running the command locally.(See https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8858721042103931248/+/steps/Host_Tests_for_host_debug_unopt/0/stdout?format=raw)
Related Issues
Replace this paragraph with a list of issues related to this PR from our issue
database. Indicate, which of these issues are resolved or fixed by this PR.
There should be at least one issue listed here.
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A
change in behaviour with no test covering it will likely get reverted
accidentally sooner or later. PRs must include tests for all
changed/updated/fixed behaviors. See testing the engine for instructions on
writing and running engine tests.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Reviewer Checklist
Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.