This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Switched engine to use buffer collection. #23488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
arbreng
approved these changes
Jan 8, 2021
Member
|
The patch needs to be rebased and the licenses fixed to proceed. |
dragostis
force-pushed
the
image2
branch
5 times, most recently
from
19e68f5 to
02f8f4b
Compare
dreveman
reviewed
Jan 21, 2021
dragostis
force-pushed
the
image2
branch
2 times, most recently
from
44b2e73 to
15403af
Compare
dreveman
reviewed
Jan 21, 2021
dreveman
suggested changes
Jan 21, 2021
dragostis
force-pushed
the
image2
branch
4 times, most recently
from
5ffcd65 to
533dc37
Compare
dreveman
approved these changes
Jan 25, 2021
Contributor
dreveman
left a comment
dreveman
left a comment
There was a problem hiding this comment.
lgtm after addressing this last set of comments
dragostis
force-pushed
the
image2
branch
2 times, most recently
from
3cfda66 to
6486ff4
Compare
The old way of allocating images meant that one would have to make sure that Scenic and Flutter were using exactly the same pixel formats. This patch removes the old image allocation and replaces it with a sysmem API that uses buffer collections instead. This permits a smooth negotiation of formats between the two systems.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2021
gnoliyil
added a commit
to gnoliyil/engine
that referenced
this pull request
Mar 5, 2021
Change flutter#23488 has switched all the Vulkan surfaces on Fuchsia to use RGBA8 color type. However, Using RGBA8 format on Intel GPUs has caused graphical artifacts on emulators (See http://fxbug.dev/70232). This change modifies vulkan_surface.cc to use the multi-format vkSetBufferCollectionImageConstraintsFUCHSIA() Vulkan API, so that it could specify multiple formats when allocating buffer collections. Bug: fxbug.dev/70232
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
The old way of allocating images meant that one would have to make sure that Scenic and Flutter were using exactly the same pixel formats. This patch removes the old image allocation and replaces it with a sysmem API that uses buffer collections instead. This permits a smooth negotiation of formats between the two systems.
freiling
added a commit
to freiling/engine
that referenced
this pull request
Mar 30, 2021
This test regressed due to flutter#23488 and this regression was silent due to flutter/flutter#78277 Credit to @gnoliyil for actually putting together the fix.
freiling
added a commit
to freiling/engine
that referenced
this pull request
Mar 30, 2021
This test regressed due to flutter#23488 and this regression was silent due to flutter/flutter#78277 Credit to @gnoliyil for actually putting together the fix.
freiling
added a commit
to freiling/engine
that referenced
this pull request
Apr 1, 2021
This test regressed due to flutter#23488 and this regression was silent due to flutter/flutter#78277 Credit to @gnoliyil for actually putting together the fix.
freiling
added a commit
that referenced
this pull request
Apr 2, 2021
…ctory when loading skp's due to high cost of openat() on pkgfs (#25006) * [fuchsia][shader warmup] Fixed SkpWarmupTest This test regressed due to #23488 and this regression was silent due to flutter/flutter#78277 Credit to @gnoliyil for actually putting together the fix. * [fuchsia][shader warmup] Avoid recursively iterating over assets directory when loading skp's due to high cost of openat() on pkgfs
duanqz
pushed a commit
to duanqz/engine
that referenced
this pull request
Apr 16, 2021
…ctory when loading skp's due to high cost of openat() on pkgfs (flutter#25006) * [fuchsia][shader warmup] Fixed SkpWarmupTest This test regressed due to flutter#23488 and this regression was silent due to flutter/flutter#78277 Credit to @gnoliyil for actually putting together the fix. * [fuchsia][shader warmup] Avoid recursively iterating over assets directory when loading skp's due to high cost of openat() on pkgfs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old way of allocating images meant that one would have to make sure that Scenic and Flutter were using exactly the same pixel formats. This patch removes the old image allocation and replaces it with a sysmem API that uses buffer collections instead. This permits a smooth negotiation of formats between the two systems.