This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix SurfaceView usage when status bar is transparent #23457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mklim
reviewed
Jan 6, 2021
xster
reviewed
Jan 6, 2021
| } | ||
| final int[] location = new int[2]; | ||
| getLocationInWindow(location); | ||
| region.op( |
There was a problem hiding this comment.
did you intend to read the output of this?
There was a problem hiding this comment.
The CL this was based on didn't use the return value. I'm not sure it's important here - I guess we could just return this value instead of returning true, but this op should always modify the region as long as the surface view is actually being used.
xster
approved these changes
Jan 6, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 6, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 6, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 6, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#73413
When the StatusBar is set to transparent, TalkBack stops working if you use a surface view.
This forces Android to recognize that we're not actually drawing a transparent region and makes TalkBack work again.
This is really a work around for a probable bug in TalkBack, but it's important because we have customers who are using a TextureView for rendering to work around this bug right now, and a TextureView carries performance penalties.
/cc @jreck
/cc @mklim @matthew-carroll who dealt with things around this in the past, FYI