Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

fixes android deeplink to push the path only #23255

Merged
merged 2 commits into from
Jan 5, 2021
Merged

fixes android deeplink to push the path only #23255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
966cbf8
fixes android deeplink to push the path only
chunhtai Dec 22, 2020
c780915
format
chunhtai Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions shell/platform/android/io/flutter/embedding/android/FlutterActivityAndFragmentDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,8 +398,8 @@ private void doInitialFlutterViewRun() {
private String maybeGetInitialRouteFromIntent(Intent intent) {
if (host.shouldHandleDeeplinking()) {
Uri data = intent.getData();
if (data != null && !data.toString().isEmpty()) {
return data.toString();
if (data != null && !data.getPath().isEmpty()) {
return data.getPath();
}
}
return null;
Expand Down
6 changes: 2 additions & 4 deletions ...orm/android/test/io/flutter/embedding/android/FlutterActivityAndFragmentDelegateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,8 +452,7 @@ public void itForwardsOnRequestPermissionsResultToFlutterEngine() {
delegate.onStart();

// Verify that the navigation channel was given the initial route message.
verify(mockFlutterEngine.getNavigationChannel(), times(1))
.setInitialRoute("http://myApp/custom/route");
verify(mockFlutterEngine.getNavigationChannel(), times(1)).setInitialRoute("/custom/route");
}

@Test
Expand Down Expand Up @@ -497,8 +496,7 @@ public void itSendsPushRouteMessageWhenOnNewIntent() {
delegate.onNewIntent(mockIntent);

// Verify that the navigation channel was given the push route message.
verify(mockFlutterEngine.getNavigationChannel(), times(1))
.pushRoute("http://myApp/custom/route");
verify(mockFlutterEngine.getNavigationChannel(), times(1)).pushRoute("/custom/route");
}

@Test
Expand Down