This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Reland path volatility tracker" #23220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 205d2b8.
renyou
approved these changes
Dec 21, 2020
dnfield
added a commit
to dnfield/engine
that referenced
this pull request
Dec 21, 2020
This reverts commit fceef3a.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 22, 2020
renyou
pushed a commit
to renyou/engine
that referenced
this pull request
Dec 22, 2020
This reverts commit 205d2b8.
dnfield
added a commit
that referenced
this pull request
Dec 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 22, 2020
renyou
added a commit
that referenced
this pull request
Dec 22, 2020
This reverts commit 205d2b8. Co-authored-by: Dan Field <[email protected]>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 22, 2020
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
Jan 5, 2021
This reverts commit 205d2b8.
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
Jan 5, 2021
…ng is requested (flutter#23226) * Reland path volatility tracker (flutter#23063)" (flutter#23220) This reverts commit fceef3a. * allow disabling based on whether deterministic rendering is needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #23063
This appears to have led to indeterminate rendering in screendiff based tests. I'll plan to reland it with a guard on
settings.skia_deterministic_rendering_on_cpuif I can validate that.@jason-simmons @renyou